From dcec2ecdd0f59b75fa87aef5fe2dabc1d6713ddb Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 13:19:04 -0300
Subject: [PATCH 01/34] feat: create isNumberFrom1To100 function

---
 src/utils.ts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/utils.ts b/src/utils.ts
index e9213ed1..96ae74c4 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -1,6 +1,6 @@
 import { NostrEvent, NSchema as n } from '@nostrify/nostrify';
 import { nip19 } from 'nostr-tools';
-import { z } from 'zod';
+import { boolean, z } from 'zod';
 
 /** Get the current time in Nostr format. */
 const nostrNow = (): number => Math.floor(Date.now() / 1000);
@@ -93,12 +93,17 @@ function isURL(value: unknown): boolean {
   return z.string().url().safeParse(value).success;
 }
 
+function isNumberFrom1To100(value: unknown): boolean {
+  return z.coerce.number().int().gte(1).lte(100).safeParse(value).success;
+}
+
 export {
   bech32ToPubkey,
   dedupeEvents,
   eventAge,
   findTag,
   isNostrId,
+  isNumberFrom1To100,
   isURL,
   type Nip05,
   nostrDate,

From 11809637ee835fdb8b2c641fbd34cd77ce278eb4 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 13:21:17 -0300
Subject: [PATCH 02/34] test(utils.ts): isNumberFrom1To100 function

---
 src/utils.test.ts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 src/utils.test.ts

diff --git a/src/utils.test.ts b/src/utils.test.ts
new file mode 100644
index 00000000..a48d0832
--- /dev/null
+++ b/src/utils.test.ts
@@ -0,0 +1,19 @@
+import { isNumberFrom1To100 } from '@/utils.ts';
+import { assertEquals } from 'https://deno.land/std@0.132.0/testing/asserts.ts';
+
+Deno.test('Value is any number from 1 to 100', () => {
+  assertEquals(isNumberFrom1To100('latvia'), false);
+  assertEquals(isNumberFrom1To100(1.5), false);
+  assertEquals(isNumberFrom1To100(Infinity), false);
+  assertEquals(isNumberFrom1To100('Infinity'), false);
+  assertEquals(isNumberFrom1To100('0'), false);
+  assertEquals(isNumberFrom1To100(0), false);
+  assertEquals(isNumberFrom1To100(-1), false);
+  assertEquals(isNumberFrom1To100('-10'), false);
+
+  for (let i = 1; i < 100; i++) {
+    assertEquals(isNumberFrom1To100(String(i)), true);
+  }
+
+  assertEquals(isNumberFrom1To100('1e1'), true);
+});

From c2225da8dd33d5e6d871705274c8510c66685cdd Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 13:34:45 -0300
Subject: [PATCH 03/34] test(utls.ts): add more cases, isNumberFrom1To100
 function

---
 src/utils.test.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/utils.test.ts b/src/utils.test.ts
index a48d0832..8adf2935 100644
--- a/src/utils.test.ts
+++ b/src/utils.test.ts
@@ -10,6 +10,8 @@ Deno.test('Value is any number from 1 to 100', () => {
   assertEquals(isNumberFrom1To100(0), false);
   assertEquals(isNumberFrom1To100(-1), false);
   assertEquals(isNumberFrom1To100('-10'), false);
+  assertEquals(isNumberFrom1To100([]), false);
+  assertEquals(isNumberFrom1To100(undefined), false);
 
   for (let i = 1; i < 100; i++) {
     assertEquals(isNumberFrom1To100(String(i)), true);

From cc6441d2397d45c963518e9ca3d9603f50cc1622 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 15:22:35 -0300
Subject: [PATCH 04/34] refactor(utils.ts): remove unused imports

---
 src/utils.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/utils.ts b/src/utils.ts
index 96ae74c4..a1c3b1d1 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -1,6 +1,6 @@
 import { NostrEvent, NSchema as n } from '@nostrify/nostrify';
 import { nip19 } from 'nostr-tools';
-import { boolean, z } from 'zod';
+import { z } from 'zod';
 
 /** Get the current time in Nostr format. */
 const nostrNow = (): number => Math.floor(Date.now() / 1000);

From c17db5844889801970eb6ade964f516f8c33e9d6 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 16:26:50 -0300
Subject: [PATCH 05/34] feat(utils.ts): create isObjectEmpty function

---
 src/utils.ts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/utils.ts b/src/utils.ts
index a1c3b1d1..de826ad6 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -97,6 +97,13 @@ function isNumberFrom1To100(value: unknown): boolean {
   return z.coerce.number().int().gte(1).lte(100).safeParse(value).success;
 }
 
+function isObjectEmpty(obj: object): boolean {
+  for (const prop in obj) {
+    if (Object.hasOwn(obj, prop)) return false;
+  }
+  return true;
+}
+
 export {
   bech32ToPubkey,
   dedupeEvents,
@@ -104,6 +111,7 @@ export {
   findTag,
   isNostrId,
   isNumberFrom1To100,
+  isObjectEmpty,
   isURL,
   type Nip05,
   nostrDate,

From 0c9e3e2b47913580bee76cbe5eed4b38b193d193 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 16:27:10 -0300
Subject: [PATCH 06/34] test(utils.ts): isObjectEmpty function

---
 src/utils.test.ts | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/src/utils.test.ts b/src/utils.test.ts
index 8adf2935..1023c633 100644
--- a/src/utils.test.ts
+++ b/src/utils.test.ts
@@ -1,5 +1,5 @@
-import { isNumberFrom1To100 } from '@/utils.ts';
-import { assertEquals } from 'https://deno.land/std@0.132.0/testing/asserts.ts';
+import { isNumberFrom1To100, isObjectEmpty } from '@/utils.ts';
+import { assertEquals } from '@std/assert';
 
 Deno.test('Value is any number from 1 to 100', () => {
   assertEquals(isNumberFrom1To100('latvia'), false);
@@ -19,3 +19,11 @@ Deno.test('Value is any number from 1 to 100', () => {
 
   assertEquals(isNumberFrom1To100('1e1'), true);
 });
+
+Deno.test('Object is empty', () => {
+  assertEquals(isObjectEmpty([1]), false);
+  assertEquals(isObjectEmpty({ 'yolo': 'no yolo' }), false);
+
+  assertEquals(isObjectEmpty([]), true);
+  assertEquals(isObjectEmpty({}), true);
+});

From 76a591ab6db38500d4ffded99938e2fdc8a0897b Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 17:20:31 -0300
Subject: [PATCH 07/34] feat: create getZapSplits function

---
 src/utils/zap_split.ts | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 src/utils/zap_split.ts

diff --git a/src/utils/zap_split.ts b/src/utils/zap_split.ts
new file mode 100644
index 00000000..68aabc8a
--- /dev/null
+++ b/src/utils/zap_split.ts
@@ -0,0 +1,35 @@
+import { NSchema as n, NStore } from '@nostrify/nostrify';
+import { isNumberFrom1To100 } from '@/utils.ts';
+
+type Pubkey = string;
+type ExtraMessage = string;
+/** Number from 1 to 100, stringified. */
+type splitPercentages = string;
+
+type DittoZapSplits = {
+  [key: Pubkey]: [splitPercentages, ExtraMessage];
+};
+
+/** Gets zap splits from NIP-78 in DittoZapSplits format. */
+export async function getZapSplits(store: NStore, pubkey: string): Promise<DittoZapSplits> {
+  const zapSplits: DittoZapSplits = {};
+
+  const [event] = await store.query([{
+    authors: [pubkey],
+    kinds: [30078],
+    '#d': ['pub.ditto.zapSplits'],
+    limit: 1,
+  }]);
+  if (!event) return {};
+
+  for (const tag of event.tags) {
+    if (
+      tag[0] === 'p' && n.id().safeParse(tag[1]).success &&
+      isNumberFrom1To100(tag[2])
+    ) {
+      zapSplits[tag[1]] = [tag[2], tag[3] ?? ''];
+    }
+  }
+
+  return zapSplits;
+}

From 3bc3e7675d5d0d9f5748fe62ef409e7bb6b02b3b Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 17:35:34 -0300
Subject: [PATCH 08/34] test: getZapSplits function

---
 src/utils/zap_split.test.ts | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 src/utils/zap_split.test.ts

diff --git a/src/utils/zap_split.test.ts b/src/utils/zap_split.test.ts
new file mode 100644
index 00000000..a439e3aa
--- /dev/null
+++ b/src/utils/zap_split.test.ts
@@ -0,0 +1,36 @@
+import { assertEquals } from '@std/assert';
+import { generateSecretKey, getPublicKey } from 'nostr-tools';
+
+import { genEvent } from '@/test.ts';
+import { getZapSplits } from '@/utils/zap_split.ts';
+import { getTestDB } from '@/test.ts';
+
+Deno.test('Get zap splits in DittoZapSplits format', async () => {
+  const { store } = await getTestDB();
+
+  const sk = generateSecretKey();
+  const pubkey = getPublicKey(sk);
+
+  const event = genEvent({
+    kind: 30078,
+    tags: [
+      ['d', 'pub.ditto.zapSplits'],
+      ['p', '47259076c85f9240e852420d7213c95e95102f1de929fb60f33a2c32570c98c4', '2', 'Patrick developer'],
+      ['p', '0461fcbecc4c3374439932d6b8f11269ccdb7cc973ad7a50ae362db135a474dd', '3', 'Alex creator of Ditto'],
+    ],
+  }, sk);
+  await store.event(event);
+
+  const eventFromDb = await store.query([{ kinds: [30078], authors: [pubkey] }]);
+
+  assertEquals(eventFromDb.length, 1);
+
+  const zapSplits = await getZapSplits(store, pubkey);
+
+  assertEquals(zapSplits, {
+    '0461fcbecc4c3374439932d6b8f11269ccdb7cc973ad7a50ae362db135a474dd': ['3', 'Alex creator of Ditto'],
+    '47259076c85f9240e852420d7213c95e95102f1de929fb60f33a2c32570c98c4': ['2', 'Patrick developer'],
+  });
+
+  assertEquals(await getZapSplits(store, 'garbage'), {});
+});

From beee0e76e78f3c0548c8b42bc7227fc516356a48 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 19:19:04 -0300
Subject: [PATCH 09/34] refactor: allow to return undefined in getZapSplits
 function

---
 src/utils/zap_split.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/utils/zap_split.ts b/src/utils/zap_split.ts
index 68aabc8a..38eecba4 100644
--- a/src/utils/zap_split.ts
+++ b/src/utils/zap_split.ts
@@ -6,12 +6,12 @@ type ExtraMessage = string;
 /** Number from 1 to 100, stringified. */
 type splitPercentages = string;
 
-type DittoZapSplits = {
+export type DittoZapSplits = {
   [key: Pubkey]: [splitPercentages, ExtraMessage];
 };
 
 /** Gets zap splits from NIP-78 in DittoZapSplits format. */
-export async function getZapSplits(store: NStore, pubkey: string): Promise<DittoZapSplits> {
+export async function getZapSplits(store: NStore, pubkey: string): Promise<DittoZapSplits | undefined> {
   const zapSplits: DittoZapSplits = {};
 
   const [event] = await store.query([{
@@ -20,7 +20,7 @@ export async function getZapSplits(store: NStore, pubkey: string): Promise<Ditto
     '#d': ['pub.ditto.zapSplits'],
     limit: 1,
   }]);
-  if (!event) return {};
+  if (!event) return;
 
   for (const tag of event.tags) {
     if (

From 09eb444c9bfb59a0a45c71dd94140d4606d39791 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 19:19:35 -0300
Subject: [PATCH 10/34] test: update so getZapSplits function returns undefined

---
 src/utils/zap_split.test.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/utils/zap_split.test.ts b/src/utils/zap_split.test.ts
index a439e3aa..9678aba9 100644
--- a/src/utils/zap_split.test.ts
+++ b/src/utils/zap_split.test.ts
@@ -32,5 +32,5 @@ Deno.test('Get zap splits in DittoZapSplits format', async () => {
     '47259076c85f9240e852420d7213c95e95102f1de929fb60f33a2c32570c98c4': ['2', 'Patrick developer'],
   });
 
-  assertEquals(await getZapSplits(store, 'garbage'), {});
+  assertEquals(await getZapSplits(store, 'garbage'), undefined);
 });

From 1f9896bdbf951e552b6eff09efc40e4979af6cae Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Fri, 19 Jul 2024 19:30:31 -0300
Subject: [PATCH 11/34] test: getZapSplits function return empty object

---
 src/utils/zap_split.test.ts | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/src/utils/zap_split.test.ts b/src/utils/zap_split.test.ts
index 9678aba9..6ccf1ada 100644
--- a/src/utils/zap_split.test.ts
+++ b/src/utils/zap_split.test.ts
@@ -34,3 +34,27 @@ Deno.test('Get zap splits in DittoZapSplits format', async () => {
 
   assertEquals(await getZapSplits(store, 'garbage'), undefined);
 });
+
+Deno.test('Zap split is empty', async () => {
+  const { store } = await getTestDB();
+
+  const sk = generateSecretKey();
+  const pubkey = getPublicKey(sk);
+
+  const event = genEvent({
+    kind: 30078,
+    tags: [
+      ['d', 'pub.ditto.zapSplits'],
+      ['p', 'baka'],
+    ],
+  }, sk);
+  await store.event(event);
+
+  const eventFromDb = await store.query([{ kinds: [30078], authors: [pubkey] }]);
+
+  assertEquals(eventFromDb.length, 1);
+
+  const zapSplits = await getZapSplits(store, pubkey);
+
+  assertEquals(zapSplits, {});
+});

From 2fe9b9f98d7e1a103179365905a5828ca936959f Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Sun, 21 Jul 2024 19:22:15 -0300
Subject: [PATCH 12/34] feat: get zap splits and return it in api/v1/instance
 endpoint

---
 src/controllers/api/instance.ts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/src/controllers/api/instance.ts b/src/controllers/api/instance.ts
index faca9c9f..1d97b1e9 100644
--- a/src/controllers/api/instance.ts
+++ b/src/controllers/api/instance.ts
@@ -4,12 +4,29 @@ import { AppController } from '@/app.ts';
 import { Conf } from '@/config.ts';
 import { Storages } from '@/storages.ts';
 import { getInstanceMetadata } from '@/utils/instance.ts';
+import { DittoZapSplits, getZapSplits } from '@/utils/zap_split.ts';
+import { createAdminEvent } from '@/utils/api.ts';
 
 const version = `3.0.0 (compatible; Ditto ${denoJson.version})`;
 
 const instanceV1Controller: AppController = async (c) => {
   const { host, protocol } = Conf.url;
   const meta = await getInstanceMetadata(await Storages.db(), c.req.raw.signal);
+  const store = c.get('store');
+
+  let zap_split: DittoZapSplits | undefined = await getZapSplits(store, Conf.pubkey);
+  if (!zap_split) {
+    const officialDittoAccountPubkey = '781a1527055f74c1f70230f10384609b34548f8ab6a0a6caa74025827f9fdae5';
+    const officialDittoAccountMsg = 'Official Ditto Account';
+    await createAdminEvent({
+      kind: 30078,
+      tags: [
+        ['d', 'pub.ditto.zapSplits'],
+        ['p', officialDittoAccountPubkey, '5', officialDittoAccountMsg],
+      ],
+    }, c);
+    zap_split = { [officialDittoAccountPubkey]: ['5', officialDittoAccountMsg] };
+  }
 
   /** Protocol to use for WebSocket URLs, depending on the protocol of the `LOCAL_DOMAIN`. */
   const wsProtocol = protocol === 'http:' ? 'ws:' : 'wss:';
@@ -68,6 +85,9 @@ const instanceV1Controller: AppController = async (c) => {
       },
     },
     rules: [],
+    ditto: {
+      zap_split,
+    },
   });
 };
 

From 2e66af26db2d5bed2cce39593afebc2b7f0b6111 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Sun, 21 Jul 2024 19:21:33 -0300
Subject: [PATCH 13/34] feat: create updateZapSplitsController

---
 src/app.ts                   |  4 ++++
 src/controllers/api/ditto.ts | 41 ++++++++++++++++++++++++++++++++----
 2 files changed, 41 insertions(+), 4 deletions(-)

diff --git a/src/app.ts b/src/app.ts
index 1cb3746b..7538fea2 100644
--- a/src/app.ts
+++ b/src/app.ts
@@ -44,6 +44,7 @@ import {
   adminSetRelaysController,
   nameRequestController,
   nameRequestsController,
+  updateZapSplitsController,
 } from '@/controllers/api/ditto.ts';
 import { emptyArrayController, emptyObjectController, notImplementedController } from '@/controllers/api/fallback.ts';
 import {
@@ -270,6 +271,9 @@ app.put('/api/v1/admin/ditto/relays', requireRole('admin'), adminSetRelaysContro
 app.post('/api/v1/ditto/names', requireSigner, nameRequestController);
 app.get('/api/v1/ditto/names', requireSigner, nameRequestsController);
 
+app.put('/api/v1/admin/ditto/zap_splits', requireRole('admin'), updateZapSplitsController);
+//app.delete('/api/v1/admin/ditto/zap_splits', requireRole('admin'), deleteZapSplitsController);
+
 app.post('/api/v1/ditto/zap', requireSigner, zapController);
 app.get('/api/v1/ditto/statuses/:id{[0-9a-f]{64}}/zapped_by', zappedByController);
 
diff --git a/src/controllers/api/ditto.ts b/src/controllers/api/ditto.ts
index 841eb861..c3381a66 100644
--- a/src/controllers/api/ditto.ts
+++ b/src/controllers/api/ditto.ts
@@ -1,14 +1,17 @@
-import { NostrEvent, NostrFilter } from '@nostrify/nostrify';
+import { NostrEvent, NostrFilter, NSchema as n } from '@nostrify/nostrify';
 import { z } from 'zod';
 
 import { AppController } from '@/app.ts';
-import { Conf } from '@/config.ts';
-import { booleanParamSchema } from '@/schema.ts';
 import { AdminSigner } from '@/signers/AdminSigner.ts';
+import { booleanParamSchema } from '@/schema.ts';
+import { Conf } from '@/config.ts';
 import { Storages } from '@/storages.ts';
 import { hydrateEvents } from '@/storages/hydrate.ts';
-import { createEvent, paginated, paginationSchema } from '@/utils/api.ts';
+import { createEvent, paginated, paginationSchema, parseBody } from '@/utils/api.ts';
 import { renderNameRequest } from '@/views/ditto.ts';
+import { getZapSplits } from '@/utils/zap_split.ts';
+import { updateListAdminEvent } from '@/utils/api.ts';
+import { addTag } from '@/utils/tags.ts';
 
 const markerSchema = z.enum(['read', 'write']);
 
@@ -148,3 +151,33 @@ export const nameRequestsController: AppController = async (c) => {
 
   return paginated(c, orig, nameRequests);
 };
+
+const zapSplitSchema = z.array(z.tuple([n.id(), z.number().int().min(1).max(100), z.string().max(500)])).min(1);
+
+export const updateZapSplitsController: AppController = async (c) => {
+  const body = await parseBody(c.req.raw);
+  const result = zapSplitSchema.safeParse(body);
+  const store = c.get('store');
+
+  if (!result.success) {
+    return c.json({ error: result.error }, 400);
+  }
+
+  const zap_split = await getZapSplits(store, Conf.pubkey);
+  if (!zap_split) {
+    return c.json({ error: 'Zap split not activated, visit `/api/v1/instance` to activate it.' }, 404);
+  }
+
+  const { data } = result;
+
+  await updateListAdminEvent(
+    { kinds: [30078], authors: [Conf.pubkey], '#d': ['pub.ditto.zapSplits'], limit: 1 },
+    (tags) =>
+      data.reduce((accumulator, currentValue) => {
+        return addTag(accumulator, ['p', currentValue[0], String(currentValue[1]), currentValue[2]]);
+      }, tags),
+    c,
+  );
+
+  return c.json(200);
+};

From 449a3497ba5aac442b2c335ddd46c86f12260e06 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Sun, 21 Jul 2024 19:40:55 -0300
Subject: [PATCH 14/34] feat: create deleteZapSplitsController

---
 src/app.ts                   |  3 ++-
 src/controllers/api/ditto.ts | 31 +++++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+), 1 deletion(-)

diff --git a/src/app.ts b/src/app.ts
index 7538fea2..f9dad138 100644
--- a/src/app.ts
+++ b/src/app.ts
@@ -42,6 +42,7 @@ import { bookmarksController } from '@/controllers/api/bookmarks.ts';
 import {
   adminRelaysController,
   adminSetRelaysController,
+  deleteZapSplitsController,
   nameRequestController,
   nameRequestsController,
   updateZapSplitsController,
@@ -272,7 +273,7 @@ app.post('/api/v1/ditto/names', requireSigner, nameRequestController);
 app.get('/api/v1/ditto/names', requireSigner, nameRequestsController);
 
 app.put('/api/v1/admin/ditto/zap_splits', requireRole('admin'), updateZapSplitsController);
-//app.delete('/api/v1/admin/ditto/zap_splits', requireRole('admin'), deleteZapSplitsController);
+app.delete('/api/v1/admin/ditto/zap_splits', requireRole('admin'), deleteZapSplitsController);
 
 app.post('/api/v1/ditto/zap', requireSigner, zapController);
 app.get('/api/v1/ditto/statuses/:id{[0-9a-f]{64}}/zapped_by', zappedByController);
diff --git a/src/controllers/api/ditto.ts b/src/controllers/api/ditto.ts
index c3381a66..aebf3427 100644
--- a/src/controllers/api/ditto.ts
+++ b/src/controllers/api/ditto.ts
@@ -12,6 +12,7 @@ import { renderNameRequest } from '@/views/ditto.ts';
 import { getZapSplits } from '@/utils/zap_split.ts';
 import { updateListAdminEvent } from '@/utils/api.ts';
 import { addTag } from '@/utils/tags.ts';
+import { deleteTag } from '@/utils/tags.ts';
 
 const markerSchema = z.enum(['read', 'write']);
 
@@ -181,3 +182,33 @@ export const updateZapSplitsController: AppController = async (c) => {
 
   return c.json(200);
 };
+
+const deleteZapSplitSchema = z.array(n.id()).min(1);
+
+export const deleteZapSplitsController: AppController = async (c) => {
+  const body = await parseBody(c.req.raw);
+  const result = deleteZapSplitSchema.safeParse(body);
+  const store = c.get('store');
+
+  if (!result.success) {
+    return c.json({ error: result.error }, 400);
+  }
+
+  const zap_split = await getZapSplits(store, Conf.pubkey);
+  if (!zap_split) {
+    return c.json({ error: 'Zap split not activated, visit `/api/v1/instance` to activate it.' }, 404);
+  }
+
+  const { data } = result;
+
+  await updateListAdminEvent(
+    { kinds: [30078], authors: [Conf.pubkey], '#d': ['pub.ditto.zapSplits'], limit: 1 },
+    (tags) =>
+      data.reduce((accumulator, currentValue) => {
+        return deleteTag(accumulator, ['p', currentValue]);
+      }, tags),
+    c,
+  );
+
+  return c.json(200);
+};

From 5a5e8b7c5d522f00f02fad69c92a3429cb636d0b Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Sun, 21 Jul 2024 20:11:26 -0300
Subject: [PATCH 15/34] feat(createStatusController): add 'zap' tag to event

---
 src/controllers/api/statuses.ts | 21 ++++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/src/controllers/api/statuses.ts b/src/controllers/api/statuses.ts
index 4604981f..c56de586 100644
--- a/src/controllers/api/statuses.ts
+++ b/src/controllers/api/statuses.ts
@@ -29,6 +29,8 @@ import { addTag, deleteTag } from '@/utils/tags.ts';
 import { asyncReplaceAll } from '@/utils/text.ts';
 import { DittoEvent } from '@/interfaces/DittoEvent.ts';
 import { accountFromPubkey, renderAccount } from '@/views/mastodon/accounts.ts';
+import { isObjectEmpty } from '@/utils.ts';
+import { getZapSplits } from '@/utils/zap_split.ts';
 
 const createStatusSchema = z.object({
   in_reply_to_id: n.id().nullish(),
@@ -71,6 +73,7 @@ const createStatusController: AppController = async (c) => {
   const body = await parseBody(c.req.raw);
   const result = createStatusSchema.safeParse(body);
   const kysely = await DittoDB.getInstance();
+  const store = c.get('store');
 
   if (!result.success) {
     return c.json({ error: 'Bad request', schema: result.error }, 400);
@@ -173,14 +176,26 @@ const createStatusController: AppController = async (c) => {
   const quoteCompat = data.quote_id ? `\n\nnostr:${nip19.noteEncode(data.quote_id)}` : '';
   const mediaCompat = mediaUrls.length ? `\n\n${mediaUrls.join('\n')}` : '';
 
+  const author = await getAuthor(await c.get('signer')?.getPublicKey() as string);
+
+  const meta = n.json().pipe(n.metadata()).catch({}).parse(author?.content);
+  const lnurl = getLnurl(meta);
+  const zap_split = await getZapSplits(store, Conf.pubkey);
+  if (lnurl && zap_split && isObjectEmpty(zap_split) === false) {
+    let totalSplit = 0;
+    for (const pubkey in zap_split) {
+      totalSplit += Number(zap_split[pubkey][0]);
+      tags.push(['zap', pubkey, Conf.relay, zap_split[pubkey][0]]);
+    }
+    tags.push(['zap', author?.pubkey as string, Conf.relay, Math.max(0, 100 - totalSplit).toString()]);
+  }
+
   const event = await createEvent({
     kind: 1,
     content: content + quoteCompat + mediaCompat,
     tags,
   }, c);
 
-  const author = await getAuthor(event.pubkey);
-
   if (data.quote_id) {
     await hydrateEvents({
       events: [event],
@@ -189,7 +204,7 @@ const createStatusController: AppController = async (c) => {
     });
   }
 
-  return c.json(await renderStatus({ ...event, author }, { viewerPubkey: await c.get('signer')?.getPublicKey() }));
+  return c.json(await renderStatus({ ...event, author }, { viewerPubkey: author?.pubkey }));
 };
 
 const deleteStatusController: AppController = async (c) => {

From 80e14c65c0ba9382c8b33af58d0ca945dd543875 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 18:14:22 -0300
Subject: [PATCH 16/34] refactor: rename zap_split.ts to zap-split.ts, rename
 tests as well

---
 src/controllers/api/ditto.ts                       | 2 +-
 src/controllers/api/instance.ts                    | 2 +-
 src/controllers/api/statuses.ts                    | 2 +-
 src/utils/{zap_split.test.ts => zap-split.test.ts} | 2 +-
 src/utils/{zap_split.ts => zap-split.ts}           | 0
 5 files changed, 4 insertions(+), 4 deletions(-)
 rename src/utils/{zap_split.test.ts => zap-split.test.ts} (97%)
 rename src/utils/{zap_split.ts => zap-split.ts} (100%)

diff --git a/src/controllers/api/ditto.ts b/src/controllers/api/ditto.ts
index aebf3427..a22dd1e5 100644
--- a/src/controllers/api/ditto.ts
+++ b/src/controllers/api/ditto.ts
@@ -9,7 +9,7 @@ import { Storages } from '@/storages.ts';
 import { hydrateEvents } from '@/storages/hydrate.ts';
 import { createEvent, paginated, paginationSchema, parseBody } from '@/utils/api.ts';
 import { renderNameRequest } from '@/views/ditto.ts';
-import { getZapSplits } from '@/utils/zap_split.ts';
+import { getZapSplits } from '@/utils/zap-split.ts';
 import { updateListAdminEvent } from '@/utils/api.ts';
 import { addTag } from '@/utils/tags.ts';
 import { deleteTag } from '@/utils/tags.ts';
diff --git a/src/controllers/api/instance.ts b/src/controllers/api/instance.ts
index 1d97b1e9..6b8a86a3 100644
--- a/src/controllers/api/instance.ts
+++ b/src/controllers/api/instance.ts
@@ -4,7 +4,7 @@ import { AppController } from '@/app.ts';
 import { Conf } from '@/config.ts';
 import { Storages } from '@/storages.ts';
 import { getInstanceMetadata } from '@/utils/instance.ts';
-import { DittoZapSplits, getZapSplits } from '@/utils/zap_split.ts';
+import { DittoZapSplits, getZapSplits } from '@/utils/zap-split.ts';
 import { createAdminEvent } from '@/utils/api.ts';
 
 const version = `3.0.0 (compatible; Ditto ${denoJson.version})`;
diff --git a/src/controllers/api/statuses.ts b/src/controllers/api/statuses.ts
index c56de586..7b0b7820 100644
--- a/src/controllers/api/statuses.ts
+++ b/src/controllers/api/statuses.ts
@@ -30,7 +30,7 @@ import { asyncReplaceAll } from '@/utils/text.ts';
 import { DittoEvent } from '@/interfaces/DittoEvent.ts';
 import { accountFromPubkey, renderAccount } from '@/views/mastodon/accounts.ts';
 import { isObjectEmpty } from '@/utils.ts';
-import { getZapSplits } from '@/utils/zap_split.ts';
+import { getZapSplits } from '@/utils/zap-split.ts';
 
 const createStatusSchema = z.object({
   in_reply_to_id: n.id().nullish(),
diff --git a/src/utils/zap_split.test.ts b/src/utils/zap-split.test.ts
similarity index 97%
rename from src/utils/zap_split.test.ts
rename to src/utils/zap-split.test.ts
index 6ccf1ada..bc9527df 100644
--- a/src/utils/zap_split.test.ts
+++ b/src/utils/zap-split.test.ts
@@ -2,7 +2,7 @@ import { assertEquals } from '@std/assert';
 import { generateSecretKey, getPublicKey } from 'nostr-tools';
 
 import { genEvent } from '@/test.ts';
-import { getZapSplits } from '@/utils/zap_split.ts';
+import { getZapSplits } from '@/utils/zap-split.ts';
 import { getTestDB } from '@/test.ts';
 
 Deno.test('Get zap splits in DittoZapSplits format', async () => {
diff --git a/src/utils/zap_split.ts b/src/utils/zap-split.ts
similarity index 100%
rename from src/utils/zap_split.ts
rename to src/utils/zap-split.ts

From de32930c441f15498d34269180c2e39bef563a0c Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 18:26:06 -0300
Subject: [PATCH 17/34] refactor: use exclamation mark (bang) instead of 'as
 string' cast

---
 src/controllers/api/statuses.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controllers/api/statuses.ts b/src/controllers/api/statuses.ts
index 7b0b7820..7823949d 100644
--- a/src/controllers/api/statuses.ts
+++ b/src/controllers/api/statuses.ts
@@ -176,7 +176,7 @@ const createStatusController: AppController = async (c) => {
   const quoteCompat = data.quote_id ? `\n\nnostr:${nip19.noteEncode(data.quote_id)}` : '';
   const mediaCompat = mediaUrls.length ? `\n\n${mediaUrls.join('\n')}` : '';
 
-  const author = await getAuthor(await c.get('signer')?.getPublicKey() as string);
+  const author = await getAuthor(await c.get('signer')?.getPublicKey()!);
 
   const meta = n.json().pipe(n.metadata()).catch({}).parse(author?.content);
   const lnurl = getLnurl(meta);

From a0c952b9b9a7bd764c28b0f7003ae2baa2a733cc Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 20:15:44 -0300
Subject: [PATCH 18/34] refactor: do not use isObjectEmpty function in if
 condition, zap tag

---
 src/controllers/api/statuses.ts | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/controllers/api/statuses.ts b/src/controllers/api/statuses.ts
index 7823949d..4b29aea2 100644
--- a/src/controllers/api/statuses.ts
+++ b/src/controllers/api/statuses.ts
@@ -29,7 +29,6 @@ import { addTag, deleteTag } from '@/utils/tags.ts';
 import { asyncReplaceAll } from '@/utils/text.ts';
 import { DittoEvent } from '@/interfaces/DittoEvent.ts';
 import { accountFromPubkey, renderAccount } from '@/views/mastodon/accounts.ts';
-import { isObjectEmpty } from '@/utils.ts';
 import { getZapSplits } from '@/utils/zap-split.ts';
 
 const createStatusSchema = z.object({
@@ -181,13 +180,15 @@ const createStatusController: AppController = async (c) => {
   const meta = n.json().pipe(n.metadata()).catch({}).parse(author?.content);
   const lnurl = getLnurl(meta);
   const zap_split = await getZapSplits(store, Conf.pubkey);
-  if (lnurl && zap_split && isObjectEmpty(zap_split) === false) {
+  if (lnurl && zap_split) {
     let totalSplit = 0;
     for (const pubkey in zap_split) {
       totalSplit += Number(zap_split[pubkey][0]);
       tags.push(['zap', pubkey, Conf.relay, zap_split[pubkey][0]]);
     }
-    tags.push(['zap', author?.pubkey as string, Conf.relay, Math.max(0, 100 - totalSplit).toString()]);
+    if (totalSplit) {
+      tags.push(['zap', author?.pubkey as string, Conf.relay, Math.max(0, 100 - totalSplit).toString()]);
+    }
   }
 
   const event = await createEvent({

From 7cdfb67b993ce66cb2071be33154f82c31c8f18a Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 20:25:02 -0300
Subject: [PATCH 19/34] refactor: rename officialDittoAccountPubkey to
 dittoPubkey & officialDittoAccountMsg to dittoMsg

---
 src/controllers/api/instance.ts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/controllers/api/instance.ts b/src/controllers/api/instance.ts
index 6b8a86a3..305f9e96 100644
--- a/src/controllers/api/instance.ts
+++ b/src/controllers/api/instance.ts
@@ -16,16 +16,16 @@ const instanceV1Controller: AppController = async (c) => {
 
   let zap_split: DittoZapSplits | undefined = await getZapSplits(store, Conf.pubkey);
   if (!zap_split) {
-    const officialDittoAccountPubkey = '781a1527055f74c1f70230f10384609b34548f8ab6a0a6caa74025827f9fdae5';
-    const officialDittoAccountMsg = 'Official Ditto Account';
+    const dittoPubkey = '781a1527055f74c1f70230f10384609b34548f8ab6a0a6caa74025827f9fdae5';
+    const dittoMsg = 'Official Ditto Account';
     await createAdminEvent({
       kind: 30078,
       tags: [
         ['d', 'pub.ditto.zapSplits'],
-        ['p', officialDittoAccountPubkey, '5', officialDittoAccountMsg],
+        ['p', dittoPubkey, '5', dittoMsg],
       ],
     }, c);
-    zap_split = { [officialDittoAccountPubkey]: ['5', officialDittoAccountMsg] };
+    zap_split = { [dittoPubkey]: ['5', dittoMsg] };
   }
 
   /** Protocol to use for WebSocket URLs, depending on the protocol of the `LOCAL_DOMAIN`. */

From 2ebaee880749c16898fcaeafaa81c1162f371966 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 20:39:23 -0300
Subject: [PATCH 20/34] refactor: change DittoZapSplits data structure to use
 object fields instead of array

---
 src/utils/zap-split.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/utils/zap-split.ts b/src/utils/zap-split.ts
index 38eecba4..33cd9c4e 100644
--- a/src/utils/zap-split.ts
+++ b/src/utils/zap-split.ts
@@ -4,10 +4,10 @@ import { isNumberFrom1To100 } from '@/utils.ts';
 type Pubkey = string;
 type ExtraMessage = string;
 /** Number from 1 to 100, stringified. */
-type splitPercentages = string;
+type splitPercentages = number;
 
 export type DittoZapSplits = {
-  [key: Pubkey]: [splitPercentages, ExtraMessage];
+  [key: Pubkey]: { amount: splitPercentages; message: ExtraMessage };
 };
 
 /** Gets zap splits from NIP-78 in DittoZapSplits format. */
@@ -27,7 +27,7 @@ export async function getZapSplits(store: NStore, pubkey: string): Promise<Ditto
       tag[0] === 'p' && n.id().safeParse(tag[1]).success &&
       isNumberFrom1To100(tag[2])
     ) {
-      zapSplits[tag[1]] = [tag[2], tag[3] ?? ''];
+      zapSplits[tag[1]] = { amount: Number(tag[2]), message: tag[3] };
     }
   }
 

From 75ad25ccac49fdf736f24427cf7eb41ea2ea236c Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 20:39:51 -0300
Subject: [PATCH 21/34] test(zap-split): update to be in accord with new data
 structure

---
 src/utils/zap-split.test.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/utils/zap-split.test.ts b/src/utils/zap-split.test.ts
index bc9527df..08454160 100644
--- a/src/utils/zap-split.test.ts
+++ b/src/utils/zap-split.test.ts
@@ -28,8 +28,8 @@ Deno.test('Get zap splits in DittoZapSplits format', async () => {
   const zapSplits = await getZapSplits(store, pubkey);
 
   assertEquals(zapSplits, {
-    '0461fcbecc4c3374439932d6b8f11269ccdb7cc973ad7a50ae362db135a474dd': ['3', 'Alex creator of Ditto'],
-    '47259076c85f9240e852420d7213c95e95102f1de929fb60f33a2c32570c98c4': ['2', 'Patrick developer'],
+    '0461fcbecc4c3374439932d6b8f11269ccdb7cc973ad7a50ae362db135a474dd': { amount: 3, message: 'Alex creator of Ditto' },
+    '47259076c85f9240e852420d7213c95e95102f1de929fb60f33a2c32570c98c4': { amount: 2, message: 'Patrick developer' },
   });
 
   assertEquals(await getZapSplits(store, 'garbage'), undefined);

From c49460e37d854ac662b6f79b10bcc3d1267922b8 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 20:41:02 -0300
Subject: [PATCH 22/34] refactor(instance.ts): use new zap_split data structure
 in ditto hard coded pubkey

---
 src/controllers/api/instance.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/controllers/api/instance.ts b/src/controllers/api/instance.ts
index 305f9e96..120f6801 100644
--- a/src/controllers/api/instance.ts
+++ b/src/controllers/api/instance.ts
@@ -25,7 +25,7 @@ const instanceV1Controller: AppController = async (c) => {
         ['p', dittoPubkey, '5', dittoMsg],
       ],
     }, c);
-    zap_split = { [dittoPubkey]: ['5', dittoMsg] };
+    zap_split = { [dittoPubkey]: { amount: 5, message: dittoMsg } };
   }
 
   /** Protocol to use for WebSocket URLs, depending on the protocol of the `LOCAL_DOMAIN`. */

From 0e43d1e8a765f22477949d69191b84810bc1ae51 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Tue, 23 Jul 2024 22:40:38 -0300
Subject: [PATCH 23/34] refactor: add zap tag with new data structure

---
 src/controllers/api/statuses.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/controllers/api/statuses.ts b/src/controllers/api/statuses.ts
index 4b29aea2..e222608c 100644
--- a/src/controllers/api/statuses.ts
+++ b/src/controllers/api/statuses.ts
@@ -183,8 +183,8 @@ const createStatusController: AppController = async (c) => {
   if (lnurl && zap_split) {
     let totalSplit = 0;
     for (const pubkey in zap_split) {
-      totalSplit += Number(zap_split[pubkey][0]);
-      tags.push(['zap', pubkey, Conf.relay, zap_split[pubkey][0]]);
+      totalSplit += zap_split[pubkey].amount;
+      tags.push(['zap', pubkey, Conf.relay, zap_split[pubkey].amount.toString()]);
     }
     if (totalSplit) {
       tags.push(['zap', author?.pubkey as string, Conf.relay, Math.max(0, 100 - totalSplit).toString()]);

From 86874e3a0869f21a40f690b64fa55a42fb140a29 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Wed, 24 Jul 2024 10:53:32 -0300
Subject: [PATCH 24/34] feat: create createZapSplitsIfNotExists() function

---
 src/utils/zap-split.ts | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/src/utils/zap-split.ts b/src/utils/zap-split.ts
index 33cd9c4e..54fe04a5 100644
--- a/src/utils/zap-split.ts
+++ b/src/utils/zap-split.ts
@@ -1,5 +1,9 @@
+import { Conf } from '@/config.ts';
 import { NSchema as n, NStore } from '@nostrify/nostrify';
-import { isNumberFrom1To100 } from '@/utils.ts';
+import { isNumberFrom1To100, nostrNow } from '@/utils.ts';
+import { Storages } from '@/storages.ts';
+import { AdminSigner } from '@/signers/AdminSigner.ts';
+import { handleEvent } from '@/pipeline.ts';
 
 type Pubkey = string;
 type ExtraMessage = string;
@@ -33,3 +37,25 @@ export async function getZapSplits(store: NStore, pubkey: string): Promise<Ditto
 
   return zapSplits;
 }
+
+export async function createZapSplitsIfNotExists() {
+  const store = await Storages.admin();
+
+  const zap_split: DittoZapSplits | undefined = await getZapSplits(store, Conf.pubkey);
+  if (!zap_split) {
+    const dittoPubkey = '781a1527055f74c1f70230f10384609b34548f8ab6a0a6caa74025827f9fdae5';
+    const dittoMsg = 'Official Ditto Account';
+
+    const signer = new AdminSigner();
+    const event = await signer.signEvent({
+      content: '',
+      created_at: nostrNow(),
+      kind: 30078,
+      tags: [
+        ['d', 'pub.ditto.zapSplits'],
+        ['p', dittoPubkey, '5', dittoMsg],
+      ],
+    });
+    await handleEvent(event, AbortSignal.timeout(5000));
+  }
+}

From 1698c1b19b30339092259133708e8e719dde2ce9 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Wed, 24 Jul 2024 10:54:20 -0300
Subject: [PATCH 25/34] feat: create startup file

---
 src/startup.ts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 src/startup.ts

diff --git a/src/startup.ts b/src/startup.ts
new file mode 100644
index 00000000..4ec75e03
--- /dev/null
+++ b/src/startup.ts
@@ -0,0 +1,16 @@
+// Starts up applications required to run before the HTTP server is on.
+
+import { Conf } from '@/config.ts';
+import { createZapSplitsIfNotExists } from '@/utils/zap-split.ts';
+import { cron } from '@/cron.ts';
+import { startFirehose } from '@/firehose.ts';
+
+if (Conf.firehoseEnabled) {
+  startFirehose();
+}
+
+if (Conf.cronEnabled) {
+  cron();
+}
+
+await createZapSplitsIfNotExists();

From 23bb24929c0d693d3186904d21e1b5606e9412fd Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Wed, 24 Jul 2024 10:54:56 -0300
Subject: [PATCH 26/34] refactor: remove zap split creation from
 instanceV1Controller endpoint

---
 src/controllers/api/instance.ts | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/src/controllers/api/instance.ts b/src/controllers/api/instance.ts
index 120f6801..5f7054ee 100644
--- a/src/controllers/api/instance.ts
+++ b/src/controllers/api/instance.ts
@@ -5,7 +5,6 @@ import { Conf } from '@/config.ts';
 import { Storages } from '@/storages.ts';
 import { getInstanceMetadata } from '@/utils/instance.ts';
 import { DittoZapSplits, getZapSplits } from '@/utils/zap-split.ts';
-import { createAdminEvent } from '@/utils/api.ts';
 
 const version = `3.0.0 (compatible; Ditto ${denoJson.version})`;
 
@@ -14,19 +13,7 @@ const instanceV1Controller: AppController = async (c) => {
   const meta = await getInstanceMetadata(await Storages.db(), c.req.raw.signal);
   const store = c.get('store');
 
-  let zap_split: DittoZapSplits | undefined = await getZapSplits(store, Conf.pubkey);
-  if (!zap_split) {
-    const dittoPubkey = '781a1527055f74c1f70230f10384609b34548f8ab6a0a6caa74025827f9fdae5';
-    const dittoMsg = 'Official Ditto Account';
-    await createAdminEvent({
-      kind: 30078,
-      tags: [
-        ['d', 'pub.ditto.zapSplits'],
-        ['p', dittoPubkey, '5', dittoMsg],
-      ],
-    }, c);
-    zap_split = { [dittoPubkey]: { amount: 5, message: dittoMsg } };
-  }
+  const zap_split: DittoZapSplits | undefined = await getZapSplits(store, Conf.pubkey) ?? {};
 
   /** Protocol to use for WebSocket URLs, depending on the protocol of the `LOCAL_DOMAIN`. */
   const wsProtocol = protocol === 'http:' ? 'ws:' : 'wss:';

From ddd1972c831b025a0a891188bcee6df69c6560f3 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Wed, 24 Jul 2024 10:55:30 -0300
Subject: [PATCH 27/34] refactor(app.ts): move cron function and startFirehose
 function to startup.ts

---
 src/app.ts | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/src/app.ts b/src/app.ts
index f9dad138..690862eb 100644
--- a/src/app.ts
+++ b/src/app.ts
@@ -5,9 +5,6 @@ import { logger } from '@hono/hono/logger';
 import { NostrEvent, NostrSigner, NStore, NUploader } from '@nostrify/nostrify';
 import Debug from '@soapbox/stickynotes/debug';
 
-import { Conf } from '@/config.ts';
-import { cron } from '@/cron.ts';
-import { startFirehose } from '@/firehose.ts';
 import { Time } from '@/utils/time.ts';
 
 import {
@@ -145,13 +142,6 @@ const app = new Hono<AppEnv>({ strict: false });
 
 const debug = Debug('ditto:http');
 
-if (Conf.firehoseEnabled) {
-  startFirehose();
-}
-if (Conf.cronEnabled) {
-  cron();
-}
-
 app.use('*', rateLimitMiddleware(300, Time.minutes(5)));
 
 app.use('/api/*', metricsMiddleware, logger(debug));

From 961da0f52cb09654955550d9dfc2a3cee12e7dd6 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Wed, 24 Jul 2024 10:56:12 -0300
Subject: [PATCH 28/34] refactor: change error message in
 updateZapSplitsController & deleteZapSplitsController

---
 src/controllers/api/ditto.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/controllers/api/ditto.ts b/src/controllers/api/ditto.ts
index a22dd1e5..f90579dd 100644
--- a/src/controllers/api/ditto.ts
+++ b/src/controllers/api/ditto.ts
@@ -166,7 +166,7 @@ export const updateZapSplitsController: AppController = async (c) => {
 
   const zap_split = await getZapSplits(store, Conf.pubkey);
   if (!zap_split) {
-    return c.json({ error: 'Zap split not activated, visit `/api/v1/instance` to activate it.' }, 404);
+    return c.json({ error: 'Zap split not activated, restart the server.' }, 404);
   }
 
   const { data } = result;
@@ -196,7 +196,7 @@ export const deleteZapSplitsController: AppController = async (c) => {
 
   const zap_split = await getZapSplits(store, Conf.pubkey);
   if (!zap_split) {
-    return c.json({ error: 'Zap split not activated, visit `/api/v1/instance` to activate it.' }, 404);
+    return c.json({ error: 'Zap split not activated, restart the server.' }, 404);
   }
 
   const { data } = result;

From 85806f7ea8aef84ed642d799acb29a1ed5548343 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Wed, 24 Jul 2024 11:14:42 -0300
Subject: [PATCH 29/34] refactor: use object fields instead of tuple in
 zapSplitSchema

---
 src/controllers/api/ditto.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/controllers/api/ditto.ts b/src/controllers/api/ditto.ts
index f90579dd..0f815350 100644
--- a/src/controllers/api/ditto.ts
+++ b/src/controllers/api/ditto.ts
@@ -153,7 +153,11 @@ export const nameRequestsController: AppController = async (c) => {
   return paginated(c, orig, nameRequests);
 };
 
-const zapSplitSchema = z.array(z.tuple([n.id(), z.number().int().min(1).max(100), z.string().max(500)])).min(1);
+const zapSplitSchema = z.array(z.object({
+  pubkey: n.id(),
+  amount: z.number().int().min(1).max(100),
+  message: z.string().max(500),
+})).min(1);
 
 export const updateZapSplitsController: AppController = async (c) => {
   const body = await parseBody(c.req.raw);
@@ -175,7 +179,7 @@ export const updateZapSplitsController: AppController = async (c) => {
     { kinds: [30078], authors: [Conf.pubkey], '#d': ['pub.ditto.zapSplits'], limit: 1 },
     (tags) =>
       data.reduce((accumulator, currentValue) => {
-        return addTag(accumulator, ['p', currentValue[0], String(currentValue[1]), currentValue[2]]);
+        return addTag(accumulator, ['p', currentValue.pubkey, currentValue.amount.toString(), currentValue.message]);
       }, tags),
     c,
   );

From f94ae7606c9c2c029e8f54a03e0d34bf7c652bc0 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Thu, 25 Jul 2024 11:11:44 -0300
Subject: [PATCH 30/34] refactor: change zapSplitSchema to z.record())

---
 src/controllers/api/ditto.ts | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/controllers/api/ditto.ts b/src/controllers/api/ditto.ts
index 0f815350..d1ba002b 100644
--- a/src/controllers/api/ditto.ts
+++ b/src/controllers/api/ditto.ts
@@ -153,11 +153,13 @@ export const nameRequestsController: AppController = async (c) => {
   return paginated(c, orig, nameRequests);
 };
 
-const zapSplitSchema = z.array(z.object({
-  pubkey: n.id(),
-  amount: z.number().int().min(1).max(100),
-  message: z.string().max(500),
-})).min(1);
+const zapSplitSchema = z.record(
+  n.id(),
+  z.object({
+    amount: z.number().int().min(1).max(100),
+    message: z.string().max(500),
+  }),
+);
 
 export const updateZapSplitsController: AppController = async (c) => {
   const body = await parseBody(c.req.raw);
@@ -174,12 +176,17 @@ export const updateZapSplitsController: AppController = async (c) => {
   }
 
   const { data } = result;
+  const pubkeys = Object.keys(data);
+
+  if (pubkeys.length < 1) {
+    return c.json(200);
+  }
 
   await updateListAdminEvent(
     { kinds: [30078], authors: [Conf.pubkey], '#d': ['pub.ditto.zapSplits'], limit: 1 },
     (tags) =>
-      data.reduce((accumulator, currentValue) => {
-        return addTag(accumulator, ['p', currentValue.pubkey, currentValue.amount.toString(), currentValue.message]);
+      pubkeys.reduce((accumulator, pubkey) => {
+        return addTag(accumulator, ['p', pubkey, data[pubkey].amount.toString(), data[pubkey].message]);
       }, tags),
     c,
   );

From 541b5b1c39aaf3bbdafeba7756b5c43231309a9e Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Thu, 25 Jul 2024 14:52:03 -0300
Subject: [PATCH 31/34] refactor: imports in alphabetical order

---
 src/controllers/api/statuses.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/controllers/api/statuses.ts b/src/controllers/api/statuses.ts
index e222608c..6a9ed1f5 100644
--- a/src/controllers/api/statuses.ts
+++ b/src/controllers/api/statuses.ts
@@ -6,10 +6,15 @@ import { nip19 } from 'nostr-tools';
 import { z } from 'zod';
 
 import { type AppController } from '@/app.ts';
+import { accountFromPubkey, renderAccount } from '@/views/mastodon/accounts.ts';
+import { addTag, deleteTag } from '@/utils/tags.ts';
+import { asyncReplaceAll } from '@/utils/text.ts';
 import { Conf } from '@/config.ts';
 import { DittoDB } from '@/db/DittoDB.ts';
+import { DittoEvent } from '@/interfaces/DittoEvent.ts';
 import { getAncestors, getAuthor, getDescendants, getEvent } from '@/queries.ts';
 import { getUnattachedMediaByIds } from '@/db/unattached-media.ts';
+import { lookupPubkey } from '@/utils/lookup.ts';
 import { renderEventAccounts } from '@/views.ts';
 import { renderReblog, renderStatus } from '@/views/mastodon/statuses.ts';
 import { Storages } from '@/storages.ts';
@@ -24,11 +29,6 @@ import {
   updateListEvent,
 } from '@/utils/api.ts';
 import { getInvoice, getLnurl } from '@/utils/lnurl.ts';
-import { lookupPubkey } from '@/utils/lookup.ts';
-import { addTag, deleteTag } from '@/utils/tags.ts';
-import { asyncReplaceAll } from '@/utils/text.ts';
-import { DittoEvent } from '@/interfaces/DittoEvent.ts';
-import { accountFromPubkey, renderAccount } from '@/views/mastodon/accounts.ts';
 import { getZapSplits } from '@/utils/zap-split.ts';
 
 const createStatusSchema = z.object({

From f3d521356d1ca64a3472ce1652755703763f9ad7 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Thu, 25 Jul 2024 14:52:52 -0300
Subject: [PATCH 32/34] refactor: get rid of isObjectEmpty function

---
 src/utils.test.ts | 11 ++---------
 src/utils.ts      |  8 --------
 2 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/src/utils.test.ts b/src/utils.test.ts
index 1023c633..d89472c6 100644
--- a/src/utils.test.ts
+++ b/src/utils.test.ts
@@ -1,6 +1,7 @@
-import { isNumberFrom1To100, isObjectEmpty } from '@/utils.ts';
 import { assertEquals } from '@std/assert';
 
+import { isNumberFrom1To100 } from '@/utils.ts';
+
 Deno.test('Value is any number from 1 to 100', () => {
   assertEquals(isNumberFrom1To100('latvia'), false);
   assertEquals(isNumberFrom1To100(1.5), false);
@@ -19,11 +20,3 @@ Deno.test('Value is any number from 1 to 100', () => {
 
   assertEquals(isNumberFrom1To100('1e1'), true);
 });
-
-Deno.test('Object is empty', () => {
-  assertEquals(isObjectEmpty([1]), false);
-  assertEquals(isObjectEmpty({ 'yolo': 'no yolo' }), false);
-
-  assertEquals(isObjectEmpty([]), true);
-  assertEquals(isObjectEmpty({}), true);
-});
diff --git a/src/utils.ts b/src/utils.ts
index de826ad6..a1c3b1d1 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -97,13 +97,6 @@ function isNumberFrom1To100(value: unknown): boolean {
   return z.coerce.number().int().gte(1).lte(100).safeParse(value).success;
 }
 
-function isObjectEmpty(obj: object): boolean {
-  for (const prop in obj) {
-    if (Object.hasOwn(obj, prop)) return false;
-  }
-  return true;
-}
-
 export {
   bech32ToPubkey,
   dedupeEvents,
@@ -111,7 +104,6 @@ export {
   findTag,
   isNostrId,
   isNumberFrom1To100,
-  isObjectEmpty,
   isURL,
   type Nip05,
   nostrDate,

From 882f8009dc9f7ad84bcc16bedd5c654977afc141 Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Thu, 25 Jul 2024 15:06:50 -0300
Subject: [PATCH 33/34] refactor: rename isNumberFrom1To100 to percentageSchema

---
 src/schema.test.ts     | 22 ++++++++++++++++++++++
 src/schema.ts          | 12 +++++++++++-
 src/utils.test.ts      | 22 ----------------------
 src/utils.ts           |  5 -----
 src/utils/zap-split.ts | 11 ++++++-----
 5 files changed, 39 insertions(+), 33 deletions(-)
 create mode 100644 src/schema.test.ts
 delete mode 100644 src/utils.test.ts

diff --git a/src/schema.test.ts b/src/schema.test.ts
new file mode 100644
index 00000000..c6b577de
--- /dev/null
+++ b/src/schema.test.ts
@@ -0,0 +1,22 @@
+import { assertEquals } from '@std/assert';
+
+import { percentageSchema } from '@/schema.ts';
+
+Deno.test('Value is any percentage from 1 to 100', () => {
+  assertEquals(percentageSchema.safeParse('latvia' as unknown).success, false);
+  assertEquals(percentageSchema.safeParse(1.5).success, false);
+  assertEquals(percentageSchema.safeParse(Infinity).success, false);
+  assertEquals(percentageSchema.safeParse('Infinity').success, false);
+  assertEquals(percentageSchema.safeParse('0').success, false);
+  assertEquals(percentageSchema.safeParse(0).success, false);
+  assertEquals(percentageSchema.safeParse(-1).success, false);
+  assertEquals(percentageSchema.safeParse('-10').success, false);
+  assertEquals(percentageSchema.safeParse([]).success, false);
+  assertEquals(percentageSchema.safeParse(undefined).success, false);
+
+  for (let i = 1; i < 100; i++) {
+    assertEquals(percentageSchema.safeParse(String(i)).success, true);
+  }
+
+  assertEquals(percentageSchema.safeParse('1e1').success, true);
+});
diff --git a/src/schema.ts b/src/schema.ts
index d152a0d4..fc7efd01 100644
--- a/src/schema.ts
+++ b/src/schema.ts
@@ -38,4 +38,14 @@ const booleanParamSchema = z.enum(['true', 'false']).transform((value) => value
 /** Schema for `File` objects. */
 const fileSchema = z.custom<File>((value) => value instanceof File);
 
-export { booleanParamSchema, decode64Schema, fileSchema, filteredArray, hashtagSchema, safeUrlSchema };
+const percentageSchema = z.coerce.number().int().gte(1).lte(100);
+
+export {
+  booleanParamSchema,
+  decode64Schema,
+  fileSchema,
+  filteredArray,
+  hashtagSchema,
+  percentageSchema,
+  safeUrlSchema,
+};
diff --git a/src/utils.test.ts b/src/utils.test.ts
deleted file mode 100644
index d89472c6..00000000
--- a/src/utils.test.ts
+++ /dev/null
@@ -1,22 +0,0 @@
-import { assertEquals } from '@std/assert';
-
-import { isNumberFrom1To100 } from '@/utils.ts';
-
-Deno.test('Value is any number from 1 to 100', () => {
-  assertEquals(isNumberFrom1To100('latvia'), false);
-  assertEquals(isNumberFrom1To100(1.5), false);
-  assertEquals(isNumberFrom1To100(Infinity), false);
-  assertEquals(isNumberFrom1To100('Infinity'), false);
-  assertEquals(isNumberFrom1To100('0'), false);
-  assertEquals(isNumberFrom1To100(0), false);
-  assertEquals(isNumberFrom1To100(-1), false);
-  assertEquals(isNumberFrom1To100('-10'), false);
-  assertEquals(isNumberFrom1To100([]), false);
-  assertEquals(isNumberFrom1To100(undefined), false);
-
-  for (let i = 1; i < 100; i++) {
-    assertEquals(isNumberFrom1To100(String(i)), true);
-  }
-
-  assertEquals(isNumberFrom1To100('1e1'), true);
-});
diff --git a/src/utils.ts b/src/utils.ts
index a1c3b1d1..e9213ed1 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -93,17 +93,12 @@ function isURL(value: unknown): boolean {
   return z.string().url().safeParse(value).success;
 }
 
-function isNumberFrom1To100(value: unknown): boolean {
-  return z.coerce.number().int().gte(1).lte(100).safeParse(value).success;
-}
-
 export {
   bech32ToPubkey,
   dedupeEvents,
   eventAge,
   findTag,
   isNostrId,
-  isNumberFrom1To100,
   isURL,
   type Nip05,
   nostrDate,
diff --git a/src/utils/zap-split.ts b/src/utils/zap-split.ts
index 54fe04a5..830c1e7c 100644
--- a/src/utils/zap-split.ts
+++ b/src/utils/zap-split.ts
@@ -1,9 +1,10 @@
-import { Conf } from '@/config.ts';
-import { NSchema as n, NStore } from '@nostrify/nostrify';
-import { isNumberFrom1To100, nostrNow } from '@/utils.ts';
-import { Storages } from '@/storages.ts';
 import { AdminSigner } from '@/signers/AdminSigner.ts';
+import { Conf } from '@/config.ts';
 import { handleEvent } from '@/pipeline.ts';
+import { NSchema as n, NStore } from '@nostrify/nostrify';
+import { nostrNow } from '@/utils.ts';
+import { percentageSchema } from '@/schema.ts';
+import { Storages } from '@/storages.ts';
 
 type Pubkey = string;
 type ExtraMessage = string;
@@ -29,7 +30,7 @@ export async function getZapSplits(store: NStore, pubkey: string): Promise<Ditto
   for (const tag of event.tags) {
     if (
       tag[0] === 'p' && n.id().safeParse(tag[1]).success &&
-      isNumberFrom1To100(tag[2])
+      percentageSchema.safeParse(tag[2]).success
     ) {
       zapSplits[tag[1]] = { amount: Number(tag[2]), message: tag[3] };
     }

From e458608e38541d2d28342ffbf1a01af98905f80f Mon Sep 17 00:00:00 2001
From: "P. Reis" <patrickpereirareal1@gmail.com>
Date: Thu, 25 Jul 2024 15:10:54 -0300
Subject: [PATCH 34/34] refactor: rename createZapSplitsIfNotExists to
 seedZapSplits

---
 src/startup.ts         | 4 ++--
 src/utils/zap-split.ts | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/startup.ts b/src/startup.ts
index 4ec75e03..21df4d50 100644
--- a/src/startup.ts
+++ b/src/startup.ts
@@ -1,7 +1,7 @@
 // Starts up applications required to run before the HTTP server is on.
 
 import { Conf } from '@/config.ts';
-import { createZapSplitsIfNotExists } from '@/utils/zap-split.ts';
+import { seedZapSplits } from '@/utils/zap-split.ts';
 import { cron } from '@/cron.ts';
 import { startFirehose } from '@/firehose.ts';
 
@@ -13,4 +13,4 @@ if (Conf.cronEnabled) {
   cron();
 }
 
-await createZapSplitsIfNotExists();
+await seedZapSplits();
diff --git a/src/utils/zap-split.ts b/src/utils/zap-split.ts
index 830c1e7c..553d9c8c 100644
--- a/src/utils/zap-split.ts
+++ b/src/utils/zap-split.ts
@@ -39,7 +39,7 @@ export async function getZapSplits(store: NStore, pubkey: string): Promise<Ditto
   return zapSplits;
 }
 
-export async function createZapSplitsIfNotExists() {
+export async function seedZapSplits() {
   const store = await Storages.admin();
 
   const zap_split: DittoZapSplits | undefined = await getZapSplits(store, Conf.pubkey);