From 6107ce88e2a8f4f0b389a31d7affd8e2e328c98a Mon Sep 17 00:00:00 2001 From: Alex Gleason Date: Thu, 10 Oct 2024 13:20:48 -0500 Subject: [PATCH] metrics: ditto_db_query_duration_ms -> ditto_db_query_duration_seconds --- src/db/KyselyLogger.ts | 6 ++++-- src/metrics.ts | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/db/KyselyLogger.ts b/src/db/KyselyLogger.ts index 72167e21..514f44a4 100644 --- a/src/db/KyselyLogger.ts +++ b/src/db/KyselyLogger.ts @@ -9,12 +9,14 @@ export const KyselyLogger: Logger = (event) => { const { query, queryDurationMillis } = event; const { sql, parameters } = query; + const queryDurationSeconds = queryDurationMillis / 1000; + dbQueriesCounter.inc(); - dbQueryDurationHistogram.observe(queryDurationMillis); + dbQueryDurationHistogram.observe(queryDurationSeconds); console.debug( sql, JSON.stringify(parameters), - `\x1b[90m(${(queryDurationMillis / 1000).toFixed(2)}s)\x1b[0m`, + `\x1b[90m(${(queryDurationSeconds / 1000).toFixed(2)}s)\x1b[0m`, ); }; diff --git a/src/metrics.ts b/src/metrics.ts index 42bcbd42..c005a6c7 100644 --- a/src/metrics.ts +++ b/src/metrics.ts @@ -97,7 +97,7 @@ export const dbAvailableConnectionsGauge = new Gauge({ }); export const dbQueryDurationHistogram = new Histogram({ - name: 'ditto_db_query_duration_ms', + name: 'ditto_db_query_duration_seconds', help: 'Duration of database queries', });