From 7687d3dd7d77f36b4f2dbcf60b69a7595eab6dd5 Mon Sep 17 00:00:00 2001
From: Siddharth Singh <me@shantaram.xyz>
Date: Sun, 6 Apr 2025 13:49:03 +0530
Subject: [PATCH] check policies when trying to store

---
 packages/ditto/controllers/api/policies.ts | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/packages/ditto/controllers/api/policies.ts b/packages/ditto/controllers/api/policies.ts
index 2995d756..e84f3d3b 100644
--- a/packages/ditto/controllers/api/policies.ts
+++ b/packages/ditto/controllers/api/policies.ts
@@ -50,6 +50,31 @@ export const adminUpdatePolicyController: AppController = async (c) => {
   try {
     const req = await c.req.json();
     const parsed = PolicySpecSchema.parse(req);
+
+    // Validate each policy against its specific schema
+    const invalidPolicies = parsed.policies.filter(policy => {
+      const policyItem = policyRegistry.available[policy.name];
+      // If policy not found in registry, it's invalid
+      if (!policyItem) {
+        return true;
+      }
+
+      try {
+        // Try to parse the policy params against the specific schema
+        policyItem.schema.parse(policy.params);
+        return false; // Not invalid
+      } catch (_) {
+        return true; // Invalid policy
+      }
+    });
+
+    // If any policies are invalid, return an error
+    if (invalidPolicies.length > 0) {
+      return c.json({
+        error: `Invalid policy specification for: ${invalidPolicies.map(p => p.name).join(', ')}`
+      }, 400);
+    }
+
     await relay.event(await createPolicyEvent(conf, parsed));
     return c.json({
       message: 'Settings saved successfully.',