From f730771d7228babd12cff6cd3e5534a7d4802f8e Mon Sep 17 00:00:00 2001
From: Alex Gleason <alex@alexgleason.me>
Date: Wed, 28 Aug 2024 14:40:45 +0200
Subject: [PATCH] metrics: track response method

---
 src/metrics.ts                      | 2 +-
 src/middleware/metricsMiddleware.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/metrics.ts b/src/metrics.ts
index e774eedc..c1fb8238 100644
--- a/src/metrics.ts
+++ b/src/metrics.ts
@@ -9,7 +9,7 @@ export const httpRequestCounter = new Counter({
 export const httpResponseCounter = new Counter({
   name: 'http_responses_total',
   help: 'Total number of HTTP responses',
-  labelNames: ['status', 'path'],
+  labelNames: ['method', 'path', 'status'],
 });
 
 export const streamingConnectionsGauge = new Gauge({
diff --git a/src/middleware/metricsMiddleware.ts b/src/middleware/metricsMiddleware.ts
index f740a745..6cf0e6de 100644
--- a/src/middleware/metricsMiddleware.ts
+++ b/src/middleware/metricsMiddleware.ts
@@ -16,5 +16,5 @@ export const metricsMiddleware: MiddlewareHandler = async (c, next) => {
   // Get a parameterized path name like `/posts/:id` instead of `/posts/1234`.
   // Tries to find actual route names first before falling back on potential middleware handlers like `app.use('*')`.
   const path = c.req.matchedRoutes.find((r) => r.method !== 'ALL')?.path ?? c.req.routePath;
-  httpResponseCounter.inc({ status, path });
+  httpResponseCounter.inc({ method, status, path });
 };