Merge branch 'resp-method' into 'main'

metrics: track response method

See merge request soapbox-pub/ditto!469
This commit is contained in:
Alex Gleason 2024-08-28 12:44:05 +00:00
commit a505372bd1
2 changed files with 2 additions and 2 deletions

View file

@ -9,7 +9,7 @@ export const httpRequestCounter = new Counter({
export const httpResponseCounter = new Counter({ export const httpResponseCounter = new Counter({
name: 'http_responses_total', name: 'http_responses_total',
help: 'Total number of HTTP responses', help: 'Total number of HTTP responses',
labelNames: ['status', 'path'], labelNames: ['method', 'path', 'status'],
}); });
export const streamingConnectionsGauge = new Gauge({ export const streamingConnectionsGauge = new Gauge({

View file

@ -16,5 +16,5 @@ export const metricsMiddleware: MiddlewareHandler = async (c, next) => {
// Get a parameterized path name like `/posts/:id` instead of `/posts/1234`. // Get a parameterized path name like `/posts/:id` instead of `/posts/1234`.
// Tries to find actual route names first before falling back on potential middleware handlers like `app.use('*')`. // Tries to find actual route names first before falling back on potential middleware handlers like `app.use('*')`.
const path = c.req.matchedRoutes.find((r) => r.method !== 'ALL')?.path ?? c.req.routePath; const path = c.req.matchedRoutes.find((r) => r.method !== 'ALL')?.path ?? c.req.routePath;
httpResponseCounter.inc({ status, path }); httpResponseCounter.inc({ method, status, path });
}; };